-
Notifications
You must be signed in to change notification settings - Fork 929
[Auth] Add MFA integration tests #5606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sam-gc/tid-tests
Are you sure you want to change the base?
Conversation
|
Binary Size ReportAffected SDKsNo changes between base commit (d44fc4c) and head commit (aa60489). Test Logs
|
Size Analysis Report |
// eslint-disable-next-line import/no-extraneous-dependencies | ||
import { | ||
applyActionCode, | ||
Auth, AuthError, ConfirmationResult, createUserWithEmailAndPassword, getMultiFactorResolver, GoogleAuthProvider, multiFactor, MultiFactorError, MultiFactorResolver, OperationType, PhoneAuthProvider, PhoneMultiFactorGenerator, RecaptchaVerifier, sendEmailVerification, signInWithCredential, signInWithCustomToken, signInWithEmailAndPassword, User, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove unused imports like signInWithCustomToken
return codes.reverse().find(({ email }) => email === toEmail)!; | ||
} | ||
|
||
async function verify() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Looks like there are some lint errors in this PR - not sure if they're intentional, would you mind taking a look at them? Thanks!
Also clean up some of the existing tests