Skip to content

[Auth] Add MFA integration tests #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sam-gc/tid-tests
Choose a base branch
from
Open

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 12, 2021

Also clean up some of the existing tests

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021

⚠️ No Changeset found

Latest commit: a36363e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (d44fc4c) and head commit (aa60489).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (d44fc4c) and head commit (aa60489).

// eslint-disable-next-line import/no-extraneous-dependencies
import {
applyActionCode,
Auth, AuthError, ConfirmationResult, createUserWithEmailAndPassword, getMultiFactorResolver, GoogleAuthProvider, multiFactor, MultiFactorError, MultiFactorResolver, OperationType, PhoneAuthProvider, PhoneMultiFactorGenerator, RecaptchaVerifier, sendEmailVerification, signInWithCredential, signInWithCustomToken, signInWithEmailAndPassword, User,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unused imports like signInWithCustomToken

@yuchenshi yuchenshi assigned sam-gc and unassigned lisajian and yuchenshi Oct 12, 2021
return codes.reverse().find(({ email }) => email === toEmail)!;
}

async function verify() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Looks like there are some lint errors in this PR - not sure if they're intentional, would you mind taking a look at them? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants